Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ci] upgrade actions/checkout to v2.4.0 #4763

Merged
merged 4 commits into from
Nov 3, 2021
Merged

[ci] upgrade actions/checkout to v2.4.0 #4763

merged 4 commits into from
Nov 3, 2021

Conversation

jameslamb
Copy link
Collaborator

This project's CI jobs running on GitHub Actions use the actions/checkout action to clone the repo at the beginning of builds. Most jobs in the repo are currently using v2.3.4 of this action (CUDA jobs are using v1).

This PR proposes upgrading all jobs to v2.4.0, the newest release of that action. Just to keep up with changes there and take advantage of small bugfixes.

See https://github.com/actions/checkout/releases for details on the newest releases of this action.

@jameslamb
Copy link
Collaborator Author

jameslamb commented Nov 2, 2021

/gha run r-solaris

Workflow Solaris CRAN check has been triggered! 🚀
https://github.com/microsoft/LightGBM/actions/runs/1414520755

solaris-x86-patched: https://builder.r-hub.io/status/lightgbm_3.3.1.99.tar.gz-9b734af66be2457db65e441b78a6f708
solaris-x86-patched-ods: https://builder.r-hub.io/status/lightgbm_3.3.1.99.tar.gz-8b1c0e2884bf437a9249afbd3c457a55
Reports also have been sent to LightGBM public e-mail: https://yopmail.com?lightgbm_rhub_checks
Status: success ✔️.

@jameslamb
Copy link
Collaborator Author

jameslamb commented Nov 2, 2021

/gha run r-valgrind

Workflow R valgrind tests has been triggered! 🚀
https://github.com/microsoft/LightGBM/actions/runs/1414521973

Status: success ✔️.

@jameslamb
Copy link
Collaborator Author

hmmm, I guess this must be the reason CUDA builds were still on actions/checkout@v1:

Syncing repository: microsoft/LightGBM
Getting Git version info
Working directory is '/home/guoke/actions-runner/_work/LightGBM/LightGBM'
/usr/bin/git version
git version 2.17.1
Deleting the contents of '/home/guoke/actions-runner/_work/LightGBM/LightGBM'
The repository will be downloaded using the GitHub REST API
To create a local Git repository instead, add Git 2.18 or higher to the PATH
Error: Input 'submodules' not supported when falling back to download using the GitHub REST API. To create a local Git repository instead, add Git 2.18 or higher to the PATH.

https://github.com/microsoft/LightGBM/runs/4086585308?check_suite_focus=true

I'll revert the changes to those jobs in this PR.

@StrikerRUS
Copy link
Collaborator

StrikerRUS commented Nov 3, 2021

We cannot use v2 on CUDA builds because of node.js installation issues: #3549 (comment).

.github/workflows/cuda.yml Outdated Show resolved Hide resolved
@jameslamb
Copy link
Collaborator Author

We cannot use v2 on CUDA builds because of node.js installation issues: #3549 (comment).

ah ok, thanks! I wasn't able to find that from search but I had a feeling there must be a specific reason I'd forgotten.

@StrikerRUS
Copy link
Collaborator

Linking #3763.

@StrikerRUS
Copy link
Collaborator

Just a note: it is OK that solaris and valgrind checks are still using 2.3.4 version.

Run actions/checkout@v2.3.4
https://github.com/microsoft/LightGBM/runs/4086606076?check_suite_focus=true#step:4:1

That happens because ChatOps CI jobs are pulling GitHub Actions Workflow configuration file from the master branch. Refer to #4503 (comment).

Copy link
Collaborator

@StrikerRUS StrikerRUS left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for updating all occurrences!

@jameslamb
Copy link
Collaborator Author

Ha right right! I keep forgetting that, sorry.

@StrikerRUS StrikerRUS merged commit 8deb909 into master Nov 3, 2021
@StrikerRUS StrikerRUS deleted the ci/gha-checkout branch November 3, 2021 15:06
@StrikerRUS StrikerRUS mentioned this pull request Jan 6, 2022
13 tasks
@jameslamb jameslamb mentioned this pull request Oct 7, 2022
40 tasks
@github-actions
Copy link

This pull request has been automatically locked since there has not been any recent activity since it was closed. To start a new related discussion, open a new issue at https://github.com/microsoft/LightGBM/issues including a reference to this.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 23, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants